Ensure WebSocket is always marked as closed after getting ConnectionClosed error #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was autogenerated by Freephite. |
jackyzha0
reviewed
Dec 17, 2024
| ) | ||
|
|
||
| await self._begin_close_session_countdown() | ||
| await self._handle_connection_closed() |
There was a problem hiding this comment.
seems like we lost the _retry_connection_callback callback here?
There was a problem hiding this comment.
That is already handled down inside close_websocket:
river-python/replit_river/session.py
Lines 454 to 455 in 235406c
jackyzha0
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When we received a
ConnectionClosederror while reading from the WebSocket, we were not marking thews_wrapperas closed. This meant that the reconnection code thought that there was already an open WebSocket connection and did not attempt reconnection. Leaving the session stuck until the grace period elapses.What changed
close_websocketafter getting aConnectionClosederror so that the bookkeeping is up to date_handle_connection_closedso its more clearclose_websocketalso handles triggering a reconnect, if enabledTest plan